Ideally, we should land #850 first but it looks like there are issue with generate-stackbrew-library.sh and the created tags.

Also, is the 8/architectures/ file correct?

Oh, I think we should add architectures onbuild & slim back?

Note sure. It's a complicated matrix of what Node v8.x.x supports and what the base image (jessie or stretch support)

Let's try and land #850 first. I'm off sick today though, won't be around for most of the day.

We need to be ready to merge updates quickly before https://nodejs.org/en/blog/vulnerability/november-2018-security-releases/ drops. We've been a bit slow getting updates out lately (due to some updates to architectures, so makes sense, of course), so just calling it out now 🙂

Yeah, we've been slower recently. I'm not really sure about #850, looks like there is still discussion going, in this case, maybe merge this one first, and send PR to official image library after #850 rebased & merged?

Yeah, let’s get this merged

Need your approval ;)

Thanks, let's merge it a little bit later, just right after the merge commit of #918 passed the CI, so we can reuse the cache to speed up this one.

@nodejs/docker Can someone do the docker hub per for this please?

docker-library/official-images#5102